Samsung phones and captive portal

Toit

#Samsung phones and captive portal

Thread channel in help

erikcorry_arbat 06/13/2023 12:59 PM

Here to discuss the troubles with Samsung phones

erikcorry_arbat 06/13/2023 01:00 PM

Samsug phones send a series of very strange DNS queries in order to determine whether they are talking to a real DNS server or being spoofed.

erikcorry_arbat 06/13/2023 01:00 PM

Rikke was kind enough to send me a dump of the DNS queries.

erikcorry_arbat 06/13/2023 01:01 PM

@Rikke

erikcorry_arbat 06/13/2023 01:01 PM

Among other things it looks up google.com.onion and www.goooooooooooooooooooooooooooooooooooooooooooooooooooooooooogle.com

Rikke 06/13/2023 01:02 PM

I can provide the DNS query from iphone, oneplus and huawei too, but not sure if it will help.

bitphlipphar 06/13/2023 01:02 PM

That's what I always do manually!

erikcorry_arbat 06/13/2023 01:02 PM

It looks to be related to this patent that I found: https://uspto.report/patent/app/20210258279

erikcorry_arbat 06/13/2023 01:03 PM

To be honest this looks like a really dumb idea. They are using machine learning to evaluate the results of probing the DNS server with strange requests.

Rikke 06/13/2023 01:06 PM

I can see the connectivitycheck.gstatic.com and this should work

erikcorry_arbat 06/13/2023 01:09 PM

The packet causing the exception looks wrong. I can't understand how it would be parseable.

erikcorry_arbat 06/13/2023 01:10 PM

So we could throw a different exception, but it would still be an exception.

erikcorry_arbat 06/13/2023 01:10 PM

Do you have to restart the device after the exception is thrown?

erikcorry_arbat 06/13/2023 01:11 PM

OUT_OF_BOUNDS
  0: ByteArrayBase_.to_string  <sdk>/core/collections.toit:1403:5
  1: parts_                    <sdk>/net/modules/dns.toit:356:16
  2: decode_name               <sdk>/net/modules/dns.toit:346:3
  3: SimpleDnsServer.lookup.<block>.<block> ../src/pkg_dns_simple_server/src/dns_simple_server.toit:90:19
  4: SmallInteger_.repeat      <sdk>/core/numbers.toit:1194:3
  5: SimpleDnsServer.lookup.<block> ../src/pkg_dns_simple_server/src/dns_simple_server.toit:89:18
  6: catch.<block>             <sdk>/core/exceptions.toit:124:10
  7: catch                     <sdk>/core/exceptions.toit:122:1
  8: catch                     <sdk>/core/exceptions.toit:73:10
  9: SimpleDnsServer.lookup    ../src/pkg_dns_simple_server/src/dns_simple_server.toit:34:18
 10: run_dns                   ../src/pkg_dns_simple_server/examples/captive_portal.toit:308:23
 11: run_portal.<lambda>       ../src/pkg_dns_simple_server/examples/captive_portal.toit:146:13

Rikke 06/13/2023 01:11 PM

No the esp continues. The textfile was a few seconds of samsung spam, and it got 2 exceptions in that time

erikcorry_arbat 06/13/2023 01:13 PM

Ah yes, there's a catch --trace in SimpleDnsServer.lookup so it keeps going.

Rikke 06/13/2023 01:21 PM

I can see

DEBUG: client connected {peer: 192.168.4.2:53410}
DEBUG: incoming request {peer: 192.168.4.2:53410, path: /gen_204}

which should be redirected, because it is in the temporary redirects

TEMPORARY_REDIRECTS ::= {
  "generate_204": "/",    // Used by Android captive portal detection.
  "gen_204": "/",         // Used by Android captive portal detection.
  // Add more redirects in order to create an alias for a file.
}

so maybe this dns spoofing thing is ruining it

erikcorry_arbat 06/13/2023 01:50 PM

Those two things should be independent.

erikcorry_arbat 06/13/2023 01:51 PM

It could be that the Samsung phone is not understanding the redirection.

erikcorry_arbat 06/13/2023 01:52 PM

The iPhones don't like. They just want the portal page to be served up under the name they use hotspot-detect.html rather than being redirected.

Rikke 06/13/2023 01:57 PM

My huawei also tries generate_204 and gen_204 and it works, so it must be a samsung thing. But hopefully not related to the spoofing thing

erikcorry_arbat 06/13/2023 02:18 PM

I've added a remove_host method to the DNS server so you can give it domains that should not get the default IP if there is a query for them.

erikcorry_arbat 06/13/2023 02:18 PM

https://github.com/toitlang/pkg-dns-simple-server/pull/7

Add remove_host method to DNS simple server by erikcorry · Pull Req...

erikcorry_arbat 06/13/2023 02:18 PM

But I think it's probably not needed here.

erikcorry_arbat 06/13/2023 02:18 PM

I think if the Samsung phone is doing the HTTP request for gen_204 then it got past the DNS problems.

erikcorry_arbat 06/13/2023 02:19 PM

So the question is why it is not responding to the answer of that request by popping up the login page.

erikcorry_arbat 06/13/2023 02:20 PM

Could be that it needs the same workaround as the iPhone with the "silent redirect" that we have for hotspot-detect.html.

erikcorry_arbat 06/13/2023 02:20 PM

Worth trying.

Rikke 06/13/2023 03:07 PM

I will try it out tomorrow

Rikke 06/14/2023 06:32 AM

Yeah it did not make cp pop up on Samsung. But this is what the phone says when its connecting to cp and spamming dns stuff. I will see if i can find a hidden request so i can redirect

Rikke 06/14/2023 06:39 AM

I do have access to an old samsung at home. I can try and see if it has the same problem

Rikke 06/14/2023 07:50 AM

Okay I've tried to redirect from different requests, but with no luck. I fear the gen_204 does not give the response it needs to detect the captive portal

I will see what my old samsung does when I get home, and see if it reveals the magic request

erikcorry_arbat 06/14/2023 07:56 AM

I released version 0.3 of the DNS simple server with that small change, so that you can respond with an unknown domain error when it asks about domains that don't exist. I suspect that you should return an error for the google.com.onion domain, and perhaps also for the gooooooooooooooooooooooooogle domain.

Rikke 06/14/2023 08:05 AM

I will try that

Rikke 06/14/2023 08:31 AM

If I call remove host on these weird websites, it should give an error on serial log? This is how I use it: run_dns is started as a task and given ip from captive portal

run_dns network/net.Interface:
  my_ip := network.address

  socket := network.udp_open --port=53

  hosts := SimpleDnsServer my_ip  // Answer my IP to all queries.
  hosts.remove_host "chat-e2ee-mini.facebook.com"
  hosts.remove_host "mqtt-mini.facebook.com"
  hosts.remove_host "www.goooooooooooooooooooooooooooooooooooooooooooooooooooooooooogle.com"
  hosts.remove_host "google.com.onion"
  hosts.remove_host "graph.facebook.com"  
  hosts.remove_host "chat-e2ee-mini.facebook.com"   
  while true:
    datagram /udp.Datagram := socket.receive
    response := hosts.lookup datagram.data
    if response:
      e := catch:
        socket.send
          udp.Datagram response datagram.address
      if e:
        //print "udp exception: $e"

I don't see any errors

Decode name:
  #[0x00, 0x11, 0x01, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x06, 0x67, 0x6f, 0x6f]
                                                                            ^^^^
  #[0x67, 0x6c, 0x65, 0x03, 0x63, 0x6f, 0x6d, 0x05, 0x6f, 0x6e, 0x69, 0x6f, 0x6e, 0x00, 0x00, 0x01]
  #[0x00, 0x01]
  Got google.com.onion
Decode name:
  #[0x00, 0x11, 0x01, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x06, 0x67, 0x6f, 0x6f]
                                                                            ^^^^
  #[0x67, 0x6c, 0x65, 0x03, 0x63, 0x6f, 0x6d, 0x05, 0x6f, 0x6e, 0x69, 0x6f, 0x6e, 0x00, 0x00, 0x01]
  #[0x00, 0x01]
  Got google.com.onion

But im no dns wizard

erikcorry_arbat 06/14/2023 10:32 AM

It doesn't print anything, just returns a DNS packet that tells the phone the domain does not exist.

erikcorry_arbat 06/14/2023 10:34 AM

if response_address == null:
          return response.create_error_ dns.ERROR_NAME

erikcorry_arbat 06/14/2023 10:34 AM

You could put a print_ here.

erikcorry_arbat 06/14/2023 10:36 AM

The long www.goooooooooooooooooooooooooooooooooooooooooooooooooooooooooogle.com actually exists though!

erikcorry_arbat 06/14/2023 10:36 AM

$ ping www.goooooooooooooooooooooooooooooooooooooooooooooooooooooooooogle.com
PING goooooooooooooooooooooooooooooooooooooooooooooooooooooooooogle.com (34.102.136.180) 56(84) bytes of data.
64 bytes from 180.136.102.34.bc.googleusercontent.com (34.102.136.180): icmp_seq=1 ttl=54 time=49.8 ms

Rikke 06/14/2023 10:56 AM

Okay .onion does not exist

and by printing I can verify it works, thanks!

I do still get the exception. It looks like each query is printed twice, and the first one sometimes fails.

Rikke 06/14/2023 10:56 AM

Decode name:
----
Received a Toit system message. Executing the command below will
make it human readable:
----
  #[0x07, 0x0e, 0x01, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x0a, 0x61, 0x6c, 0x74]

***
EXCEPTION error. 
OUT_OF_BOUNDS
  0: ByteArrayBase_.to_string  <sdk>/core/collections.toit:1403:5
  1: parts_                    <sdk>/net/modules/dns.toit:356:16
  2: decode_name               <sdk>/net/modules/dns.toit:346:3
  3: SimpleDnsServer.lookup.<block>.<block> ../src/pkg_dns_simple_server/src/dns_simple_server.toit:105:19
  4: SmallInteger_.repeat      <sdk>/core/numbers.toit:1194:3
  5: SimpleDnsServer.lookup.<block> ../src/pkg_dns_simple_server/src/dns_simple_server.toit:104:18
  6: catch.<block>             <sdk>/core/exceptions.toit:124:10
  7: catch                     <sdk>/core/exceptions.toit:122:1
  8: catch                     <sdk>/core/exceptions.toit:73:10
  9: SimpleDnsServer.lookup    ../src/pkg_dns_simple_server/src/dns_simple_server.toit:51:18
 10: run_dns                   ../src/pkg_dns_simple_server/examples/captive_portal.toit:288:23
 11: run_portal.<lambda>       ../src/pkg_dns_simple_server/examples/captive_portal.toit:148:13
***

                                                                            ^^^^
  #[0x33, 0x2d, 0x6d, 0x74, 0x61, 0x6c, 0x6b, 0x06, 0x67, 0x6f, 0x6f, 0x67, 0x6c, 0x65, 0x03, 0x63]
  #[0x6f, 0x6d, 0x00, 0x00, 0x01, 0x00, 0x01]
  Got alt3-mtalk.google.com
Decode name:
  #[0x07, 0x0e, 0x01, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x0a, 0x61, 0x6c, 0x74]
                                                                            ^^^^
  #[0x33, 0x2d, 0x6d, 0x74, 0x61, 0x6c, 0x6b, 0x06, 0x67, 0x6f, 0x6f, 0x67, 0x6c, 0x65, 0x03, 0x63]
  #[0x6f, 0x6d, 0x00, 0x00, 0x01, 0x00, 0x01]
  Got alt3-mtalk.google.com

Rikke 06/14/2023 10:58 AM

The 2nd "Decode name:" is where the print from remove_hosts is being printed:

Decode name:
  #[0x58, 0x16, 0x01, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x09, 0x6d, 0x71, 0x74]
                                                                            ^^^^
  #[0x74, 0x2d, 0x6d, 0x69, 0x6e, 0x69, 0x08, 0x66, 0x61, 0x63, 0x65, 0x62, 0x6f, 0x6f, 0x6b, 0x03]
  #[0x63, 0x6f, 0x6d, 0x00, 0x00, 0x01, 0x00, 0x01]
  Got mqtt-mini.facebook.com
Decode name:
  #[0x58, 0x16, 0x01, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x09, 0x6d, 0x71, 0x74]
                                                                            ^^^^
  #[0x74, 0x2d, 0x6d, 0x69, 0x6e, 0x69, 0x08, 0x66, 0x61, 0x63, 0x65, 0x62, 0x6f, 0x6f, 0x6b, 0x03]
  #[0x63, 0x6f, 0x6d, 0x00, 0x00, 0x01, 0x00, 0x01]
  Got mqtt-mini.facebook.com
NO I DONT LIKE

Rikke 06/14/2023 11:08 AM

It looks like something is not cleared, here's two(of the same) google.com where the last one is different from first one. The next two(of the same) will have the first one fail.
I dont know if this helps with debugging, but I attached 2 files with dns query prints in decode_name around the exception

erikcorry_arbat 06/14/2023 04:05 PM

The exception should be harmless. because it is caught and the server keeps going.

erikcorry_arbat 06/14/2023 04:06 PM

In the next release of Toit it will be more informative, but there will still be an exception.

erikcorry_arbat 06/14/2023 04:06 PM

As far as I can tell the DNS packet we get is corrupt so there's not a lot we can do.

Rikke 06/14/2023 04:15 PM

Okay

erikcorry_arbat 06/15/2023 08:56 AM

@bmentink

is having similar problems with Motorola.

erikcorry_arbat 06/15/2023 08:56 AM

I wonder if it's a general Android problem.

erikcorry_arbat 06/15/2023 08:56 AM

Last I checked it worked fine with my Google phone.

Rikke 06/15/2023 09:15 AM

Samsung s4 mini does not automatically open CP, even though it tries gen_204 and generate_204.
OnePlus 6 works as expected.
Huawei p 2019 smart asks if I want to open a login page after connecting to wifi hotspot
iphone 8 works with the /hotspot-detect.html redirect to index.html
Samsung S21+ does not automatically open CP, even though it tries gen_204 and generate_204. But I can open it myself by entering ip 192.168.4.1

I've looked online for ways to automatically open CP on all phones, but it seems like its a general problem. Each phone brand behaves differently, so its not even a question of android or iphone

Rikke 06/15/2023 09:16 AM

I think i stole one of our salesmen's new iphone, and it worked as expected. Most likely because of the redirect

Rikke 06/15/2023 10:18 AM

Okay I hijacked someone with a motorola g62 5g and it worked. first time connecting to the hotspot, it took like 20 sec to open it automatically. the 2nd time it opened instantly

Rikke 06/15/2023 10:20 AM

The huawei can consistently produce this exception when connecting, but it works as expected really. The esp does not restart because they catch the exception

**
EXCEPTION error. 
Connection closed
  0: tcp_write_                <sdk>/net/modules/tcp.toit:199:3
  1: TcpSocket.write           <sdk>/net/modules/tcp.toit:165:16
  2: Writer.write              <sdk>/writer.toit:39:23
  3: ChunkedWriter.write_header_ <pkg:pkg-http>/chunked.toit:92:13
  4: ChunkedWriter.write       <pkg:pkg-http>/chunked.toit:72:5
  5: ResponseWriter_.write     <pkg:pkg-http>/server.toit:124:18
  6: handle.<block>            ../src/pkg_dns_simple_server/examples/captive_portal.toit:264:12
  7: Map.get.<block>           <sdk>/core/collections.toit:2699:33
  8: HashedInsertionOrderedCollection_.find_body_ <sdk>/core/collections.toit:2176:3
  9: HashedInsertionOrderedCollection_.find_ <sdk>/core/collections.toit:2155:12
 10: Map.get                   <sdk>/core/collections.toit:2699:15
 11: Map.get                   <sdk>/core/collections.toit:2679:12
 12: handle                    ../src/pkg_dns_simple_server/examples/captive_portal.toit:261:26
 13: run_portal.<lambda>.<lambda> ../src/pkg_dns_simple_server/examples/captive_portal.toit:159:13
 14: Server.run_connection_.<block> <pkg:pkg-http>/server.toit:93:17
 15: catch.<block>             <sdk>/core/exceptions.toit:124:10
 16: catch                     <sdk>/core/exceptions.toit:122:1
 17: catch                     <sdk>/core/exceptions.toit:97:10
 18: Server.run_connection_    <pkg:pkg-http>/server.toit:92:7
 19: Server.listen.<lambda>.<block>.<block> <pkg:pkg-http>/server.toit:67:24
 20: catch.<block>             <sdk>/core/exceptions.toit:124:10
 21: catch                     <sdk>/core/exceptions.toit:122:1
 22: catch                     <sdk>/core/exceptions.toit:73:10
 23: Server.listen.<lambda>.<block> <pkg:pkg-http>/server.toit:66:16
 24: Server.listen.<lambda>    <pkg:pkg-http>/server.toit:53:24
**

erikcorry_arbat 06/15/2023 10:59 AM

Every phone producer that customizes Android makes it worse

Rikke 06/15/2023 12:02 PM

Yup

erikcorry_arbat 06/15/2023 12:21 PM

Happy to report that my Google Pixel still goes to the portal immediately.

erikcorry_arbat 06/15/2023 12:21 PM

I live in such a bubble that I don't know anyone who doesn't have an iPhone or a Pixel.

erikcorry_arbat 06/15/2023 12:21 PM

I took a look at how other do it, and there's an interesting list here:
https://github.com/23ewrdtf/Captive-Portal/blob/master/dnsmasq.conf

Captive-Portal/dnsmasq.conf at master · 23ewrdtf/Captive-Portal

Easy to setup Captive Portal on Raspberry Pi. Contribute to 23ewrdtf/Captive-Portal development by creating an account on GitHub.

erikcorry_arbat 06/15/2023 12:22 PM

Perhaps you should try adding all these to the DNS server with the own address, and returning an error for all others (not having a default IP).

erikcorry_arbat 06/15/2023 12:22 PM

I'm not sure why they have the correct IP address for each of those - feels like that's not useful on a captive portal that can't route to those correct addresses.

erikcorry_arbat 06/15/2023 12:26 PM

If people's phones are on Android 11 by now (it's from 2020) then we could use this technique : https://developer.android.com/about/versions/11/features/captive-portal

Captive portal API support | Android Developers

erikcorry_arbat 06/15/2023 12:38 PM

Something like this.

diff --git a/examples/captive_portal.toit b/examples/captive_portal.toit
index 418bab8..d8320b2 100644
--- a/examples/captive_portal.toit
+++ b/examples/captive_portal.toit
@@ -23,6 +23,17 @@ import .website.resources
 CAPTIVE_PORTAL_SSID     ::= "mywifi"
 CAPTIVE_PORTAL_PASSWORD ::= "12345678"
 
+PORTAL_PROBES ::= [
+    "hotspot.localnet",
+    "connectivitycheck.gstatic.com",
+    "www.gstatic.com",
+    "www.apple.com",
+    "captive.apple.com",
+    "clients3.google.com",
+    "www.msftconnecttest.com",
+    "connectivitycheck.platform.hicloud.com",
+]
+
 // On the device we use port 80 for the web server, but that is not
 // available to non-privileged users on desktop systems, so we fall
 // back on this port when testing on desktop Toit.
@@ -123,7 +134,10 @@ run_dns network/net.Interface:
 
   socket := network.udp_open --port=53
 
-  hosts := SimpleDnsServer my_ip  // Answer my IP to all queries.
+  hosts := SimpleDnsServer  // DNS server with no default answer.
+
+  PORTAL_PROBES.do:
+    hosts.add_host it my_ip  // Answer my IP to the known probe domains.
 
   while true:
     datagram /udp.Datagram := socket.receive

erikcorry_arbat 06/15/2023 12:39 PM

This still works with my Pixel, perhaps it's better with Samsung.

erikcorry_arbat 06/15/2023 01:41 PM

This says you have to use a specific IP range (200.200.'200.0/24) to persuade Samsung phones. Something we can also look into. Putting the link here so I don't forget it. https://stackoverflow.com/questions/59588154/captive-portal-for-android-phone-did-not-pop-up/59643642#59643642

Captive Portal for Android Phone did not pop up

I used hostapd, dnsmasq and apache2 for implementing the wifi-hotspot with captive portal on my Raspberry Pi 3B+, before I implement this project, I have never get in touch with wifi networks. Henc...

Rikke 06/15/2023 02:03 PM

Only samsung is a problem (and thats what i use now yay

). I will try and add these probe sites, and see if I can trick samsung. After that I will see if I can set the dns server ip to 200.200.200.1 and DHCP server range to 200.200.200.10 - 200.200.200.250.

(edited)

Rikke 06/15/2023 02:04 PM

Maybe i dont need to set the dns server ip

erikcorry_arbat 06/15/2023 02:18 PM

Yes I think if you set the address to 200.200.200.0 with mask 255.255.255.0 then it automatically sets the DNS server's IP.

erikcorry_arbat 06/15/2023 02:21 PM

I don't see how to do that right now though.

Rikke 06/16/2023 06:51 AM

Adding the PORTAL_PROBES did not make the CP pop up samsung

erikcorry_arbat 06/16/2023 08:50 AM

You removed the default too?

Rikke 06/16/2023 09:02 AM

yes remove the "my_ip" part and add all the hosts from PORTAL_PROBES(edited)

erikcorry_arbat 06/16/2023 12:33 PM

We don't have a way to configure the IP address of the soft AP at the moment.

This patch will permanently move it to 200.200.200.0/24

diff --git a/src/resources/wifi_esp32.cc b/src/resources/wifi_esp32.cc
index 11fd104b..b6e629f3 100644
--- a/src/resources/wifi_esp32.cc
+++ b/src/resources/wifi_esp32.cc
@@ -384,7 +384,14 @@ PRIMITIVE(init) {
   // because they do not correctly check for malloc failure.
   esp_netif_t* netif = null;
   if (ap) {
+    esp_netif_ip_info_t two_hundred_network;
+    two_hundred_network.ip.addr = ESP_IP4TOADDR( 200, 200, 200, 1);
+    two_hundred_network.gw.addr = ESP_IP4TOADDR( 200, 200, 200, 1);
+    two_hundred_network.netmask.addr = ESP_IP4TOADDR( 255, 255, 255, 0);
+    esp_netif_inherent_config_t netif_config = ESP_NETIF_INHERENT_DEFAULT_WIFI_AP();
+    netif_config.ip_info = &two_hundred_network;
     esp_netif_config_t netif_ap_config = ESP_NETIF_DEFAULT_WIFI_AP();
+    netif_ap_config.base = &netif_config;
     netif = esp_netif_new(&netif_ap_config);
   } else {
     esp_netif_config_t netif_sta_config = ESP_NETIF_DEFAULT_WIFI_STA();

OPerikcorry_arbat

We don't have a way to configure the IP address of the soft AP at the moment. This patch will permanently move it to 200.200.200.0/24 ``` diff --git a/src/resources/wifi_esp32.cc...

Rikke 06/16/2023 12:57 PM

This gave me the prompt "log into wifi"

so this is what it needs

Rikke 06/16/2023 12:59 PM

Hmm but does not allow me to href because its using the samsung captive portal app/thing for site connectivitycheck.gstatic.com. This should be fixable in the html(edited)

erikcorry_arbat 06/16/2023 01:39 PM

Did you change the IP address in the DNS server to match (200.200.200.1)?

Rikke 06/16/2023 04:25 PM

I just applied your patch

bmentink 06/20/2023 07:48 PM

Does the above patch fix the issues? If so will it go into a following release?

bmentink

Does the above patch fix the issues? If so will it go into a following release?

Rikke 06/21/2023 06:27 AM

it fixes the issue with captive portal not being detected on samsung phones, but its only tested on samsung galazy s22+

Rikke 06/21/2023 06:27 AM

I tested on:
Ubuntu 22.04 PC
Samsung Galaxy S22+
Huawei P 2019 Smart
IPhone 8
Motorola G62 5G

OPerikcorry_arbat

Did you change the IP address in the DNS server to match (200.200.200.1)?

Rikke 06/21/2023 06:29 AM

and yes, it changed the captive portal site from 192.168.4.1 to 200.200.200.1

bmentink 06/21/2023 06:58 AM

@Rikke

how can I test this on my Motorola phone, I don't have a build setup..

bmentink

@Rikke how can I test this on my Motorola phone, I don't have a build setup..

Rikke 06/21/2023 07:07 AM

The motorola i tested on, worked fine without this patch. but I just apply the patch in the toit git repo and rebuild the sdk.
this is the script i use

#! /bin/bash

cd toit/

export IDF_PATH=$PWD/third_party/esp-idf
$IDF_PATH/install.sh
source $IDF_PATH/export.sh
make all
make esp32

Rikke 06/21/2023 07:09 AM

Have you tested on other devices than your motorola?

bmentink 06/21/2023 07:49 AM

Yep, all Apple devices seem fine..

bmentink 06/21/2023 07:50 AM

Also macos MacBook air m1 works ok(edited)

bmentink 06/21/2023 07:53 AM

My Motorola phone that didn't work is a G9 play

Rikke 06/21/2023 07:54 AM

Its worth a try with the patch then

bmentink 06/21/2023 07:56 AM

Once you have built the sdk how do you get Artemis to use it? I haven't attempted a build of toit yet

Rikke 06/21/2023 07:57 AM

I dont use artemis so I dont know

bmentink 06/21/2023 07:58 AM

Oh, ok to hard for me then, I will wait to see if it goes into a release..

Rikke 06/21/2023 08:09 AM

You can always navigate to 192.168.4.1 if it does not automatically pop up for your device

bmentink 06/21/2023 07:34 PM

Can't have the customer do that..

Rikke 06/22/2023 06:45 AM

It actually worked fine with our technicians who installed our equipment

Rikke 06/22/2023 06:47 AM

But its nicer when it works on all devices, but captive portal pop-up isn't that straightforward. A few minutes of research and you discover each phone brand decides to do things differently

bmentink

Once you have built the sdk how do you get Artemis to use it? I haven't attempted a build of toit yet

floitsch 06/23/2023 08:22 AM

Next release of Artemis should have support for custom firmware builds.

Rikke 08/22/2023 08:58 AM

Looks like this captive portal with dns change does not work on windows 11 pc

i will investigate

Rikke 08/22/2023 10:41 AM

redirects, like with iphone, works for windows as well.

// WINDOWS PC works on 10 Pro and 11
  else if path == "/connecttest.txt": path = "index.html" // to fix windows pc captive problem
  else if path == "/redirect": path = "index.html" // to fix windows pc captive problem

Rikke 08/22/2023 10:43 AM

It looks like it tries /connecttest.txt first and gets redirected to /redirect, but i had to redirect /redirect to open the site. two other possible checking sites are /canonical.html and /success.txt?ipv4 but i did not need them for win 10 pro and win 11

erikcorry 08/22/2023 11:33 AM

Thanks I'll add that too.

bmentink 08/25/2023 10:13 PM

Can you give the complete handling for handle_http_request. i.e post the code please ..

bmentink 08/25/2023 10:14 PM

I curently have the following in setup.toit:(edited)

bmentink 08/25/2023 10:14 PM

handle_http_request request/http.Request writer/http.ResponseWriter access_points/List -> Map?:
  query := url.QueryString.parse request.path
  resource := query.resource
  if resource == "/": resource = "index.html"
  if resource == "/hotspot-detect.html": resource = "index.html"  // Needed for iPhones.
  if resource.starts_with "/": resource = resource[1..]

Rikke 08/28/2023 06:28 AM

handle request/http.Request writer/http.ResponseWriter -> none:
  path := request.path
  if path == "/": path = "index.html" 
  else if path == "/hotspot-detect.html": path = "index.html"
  else if path == "/connecttest.txt": path = "index.html"
  else if path == "/redirect": path = "index.html"

bmentink 09/02/2023 10:20 PM

I am having lot's of trouble connecting using captive portal ever since to artemis > 0.9.0 or when CP used 200.200.200.1 ip's , can someone please look at the following log to see any clues ..thanks

bmentink 09/02/2023 10:21 PM

@erikcorry_arbat

or @Rikke

bmentink

I am having lot's of trouble connecting using captive portal ever since to artemis > 0.9.0 or when CP used 200.200.200.1 ip's , can someone please look at the following log to see...

floitsch 09/04/2023 09:36 AM

I have the experience that the routers don't like too much when a device establishes connections frequently. Could that be a reason for your issues?

bmentink 09/04/2023 09:08 PM

This is my latest attempt. This time an out of memery error, I have no idea what is going on. Getting very frustrated as I am mean't to be shipping this product soon ..

bmentink 09/04/2023 09:09 PM

Is there the latest version of artemis-zygote somewhere I can check against my code?

bitphlipphar 09/05/2023 04:53 AM

@bmentink

It looks pretty weird that you're getting out-of-memory when you have lots of free memory. Also, the SSID looks a bit iffy with the + signs in there. Are they typed in as spaces?

bitphlipphar 09/05/2023 04:59 AM

The https://libs.toit.io/encoding/url/library-summary#decode(1%2C0%2C0%2C) method doesn't change + into , so maybe that is causing you some issues here. @erikcorry probably knows the rationale for this, but maybe the QueryString should be extended with a convenient way to do fix the + signs as part of decoding a query?

bitphlipphar 09/05/2023 05:01 AM

Reading more about this, I think we should fix QueryString.parse to take care of +. See https://stackoverflow.com/questions/2678551/when-should-space-be-encoded-to-plus-or-20#:~:text=So%2C%20only%20after%20%22%3F%22,encode%20spaces%20as%20%22%2B%22..

When should space be encoded to plus (+) or %20?

Sometimes the spaces get URL encoded to the + sign, and some other times to %20. What is the difference and why should this happen?

bitphlipphar 09/05/2023 06:41 AM

https://github.com/toitlang/toit/pull/1793

Decode form-urlencoded components of query strings by kasperl · Pul...

bitphlipphar

@bmentink It looks pretty weird that you're getting out-of-memory when you have lots of free memory. Also, the SSID looks a bit iffy with the + signs in there. Are t...

bmentink 09/05/2023 07:01 AM

Hi @bitphlipphar yes that particular SSID had spaces, which were converted to + , maybe we should support this?

bitphlipphar 09/05/2023 07:02 AM

@bmentink

Fix is submitted for review

erikcorry 09/05/2023 08:19 AM

Getting an OOM when there is 48k free could be one of two things:
1) We reserve 160k for malloc, and the rest can be used for either malloc or Toit heap. If you use much less than expected for malloc then you could get an out-of-memory despite having free memory (that is malloc-only).
Certain usage patterns could also cause this if you have a lot of mallocs that are in the common area instead of the malloc-only area, I haven't seen that happen, but it's theoretically possible.
2) One of your programs is trying to make a single very large allocation, 48k+.

erikcorry 09/05/2023 08:47 AM

In case it's 1) we will try a smaller malloc-only area in the next release: https://github.com/toitlang/toit/pull/1794

Reduce only-for-malloc area from 160k to 108k by erikcorry · Pull R...

For non-SPIRAM ESP32s, this increases the size of the heap metadata from 12k to 16k, but may help for systems that have large Toit heaps and low amounts of malloced memory.

bmentink

I am having lot's of trouble connecting using captive portal ever since to artemis > 0.9.0 or when CP used 200.200.200.1 ip's , can someone please look at the following log to see...

erikcorry 09/05/2023 08:49 AM

It looks like the device was power cycled in this trace

erikcorry 09/05/2023 08:49 AM

[wifi] DEBUG: connected
[wifi] INFO: network address statically assigned {ip: 200.200.200.1}
[wifi] INFO: dns server address not supplied by network; using fallback dns servers
ets Jul 29 2019 12:21:46

rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00

bitphlipphar 09/05/2023 12:54 PM

@bmentink

Artemis v0.9.7 is out and it comes with a fix for the QueryString.parse issues with +.

121 messages in total